When *should* old style numbers be used?

Not sure if this is too subjective but here goes…

Using fonts like newpx and ebgaramond, the old style figures options seem to affect all figures (as in numbers) in the document.
Is this good typography? If not, is there any guidance on when and how to apply liningnums to some elements?

In the example below we have:
chapter & section numbers, numeric citations, a footnote, inline math*, an equation*, enumeration, figure number, and inline numbers.
I’d appreciate any guidance about whether old style figures should / not be used in any of these, though I take it math (*) probably should always be lining (non-old style) figures.

---